Add a way to persist theme selection #941
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
Published version: @draftbit/ui@49.6.8-f99c50.2 |
| }); | ||
|
|
||
| React.useEffect(() => { | ||
| const run = async () => { |
There was a problem hiding this comment.
Consider if the UI shakes slightly during initialization due to the absence of a wait state when loading the theme.
👉 Example: the UI may briefly display with theme1 before switching to theme2, causing a flicker.
If thorough testing shows no issue, you can disregard this comment.
There was a problem hiding this comment.
Since storage is async, the only way to fix an eventual flicker would be to render nothing and wait on the storage to give back data. Let see if the current approach is working and fix it if it causes flickers!
There was a problem hiding this comment.
I thought about the same thing, but saw no flicker during testing. We can always come back to it and fix if the issue does arise at some point.
| }); | ||
|
|
||
| React.useEffect(() => { | ||
| const run = async () => { |
There was a problem hiding this comment.
Since storage is async, the only way to fix an eventual flicker would be to render nothing and wait on the storage to give back data. Let see if the current approach is working and fix it if it causes flickers!
YoussefHenna
deleted the
youssef/p-5355-add-a-way-to-persist-theme-selection
branch
Summary:
This PR adds theme persistence using AsyncStorage and updates jest setup files to mock AsyncStorage for testing.
Key points:
@react-native-async-storage/async-storageto dependencies.AsyncStorageinProvider.tsx.SAVED_SELECTED_THEME_KEYconstant for storage key.changeThemefunction to acceptChangeThemeOptions.React.useEffectto load persisted theme on initialization.useChangeThemehook to supportChangeThemeOptions.Generated with ❤️ by ellipsis.dev